[vpp-dev] FD.io - Gerrit 2.16 Changes

Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco)

Hi Klement.

%private avoids triggering verify jobs,

and you can use UI to set the desired state after that.


Based on my testing [0], "Unmark private" action triggers

verify jobs if and only if "fd.io JJB" is in reviewers list

(same as with "recheck" comment).


From what I can see, Jenkins allows some tweaking

using "Exclude WIP Changes" flag in trigger configuration,

but I do not see any support for that flag in Jenkins Job Builder.




[0] https://gerrit.fd.io/r/c/csit/+/20983


From: vpp-dev@... <vpp-dev@...> On Behalf Of Klement Sekera via Lists.Fd.Io
Sent: Wednesday, July 31, 2019 4:29 PM
To: Vanessa Valderrama <vvalderrama@...>; ci-management-dev@...; cicn-dev@...; csit-dev@...; deb-dpdk@...; discuss@...; dmm-dev@...; govpp-dev@...; hc2vpp@...; honeycomb-dev@...; infra-container@...; infra-steering@...; nsh_sfc-dev@...; odp4vpp-dev@...; one-dev@...; p4vpp-dev@...; pma-tools-dev@...; puppet-fdio@...; rpm_dpdk@...; sweetcomb-dev@...; tldk-dev@...; trex-dev@...; tsc@...; vpp-dev@...; jvpp-dev@...; hicn-dev@...
Cc: vpp-dev@...
Subject: Re: [vpp-dev] FD.io - Gerrit 2.16 Changes


Hi Vanessa,


I pushed a couple of changes via your suggested


git push origin HEAD:refs/for/master%wip


and I noticed that on all of these the verify jobs were (attempted to) run. One of the advantages of draft changes is that it doesn’t eat resources for pointless verify jobs.






Changes that will happen with Gerrit:

1) The 'New UI' for Gerrit will become the default UI

2) The Draft work flow is removed and replaced with 'Work in Progress'
aka 'WIP' and 'Private' workflows. Unfortunately git-review does not
support either of these workflows directly. Utilizing them means either
pushing your changes the manual way for either system or pushing them up
with git-review and then marking the change via the UI into either of
the workflows.

To push a private change you may do so as follows:
git push origin HEAD:refs/for/master%private

To pull it out of private you may do so as follows:
git push origin HEAD:refs/for/master%remove-private

To push a WIP you may do so as follows:
git push origin HEAD:refs/for/master%wip

To mark it ready for review you may do so as follows:
git push origin HEAD:refs/for/master%ready

Once a change is in either private or WIP state it does not switch the
change to a ready state until the current state has been removed.

In both cases, the state can be set via the UI by selecting the tripple
dot menu option on the change and selecting the appropriate option.

To remove WIP state press the 'START REVIEW' button. To remove the
private state you must do so via the menu.

NOTE: We are not moving to Gerrit 3 at this time. That is on the road
map but we need to come to the latest 2.x as we have to do various
migrations that are only available at the 2.16 level before we can move
to Gerrit 3.

Thank you,