nsh_sfc-dev@lists.fd.io | First patch and a request of committers

Home Messages Hashtags Subgroups

Date Date 1 - 8 of 8

First patch and a request of committers

Keith Burns <alagalah@...> #69 The patch to move nsh from VPP to nsh_sfc is published. I'd ask though that we don't merge it in lieu of a request. I'd like to rename the repo: nshsfc from nsh_sfc Can I get a vote from committers +1/-1/0 and if it passes I'll make a formal request to TSC and then helpdesk to have it changed. Would much rather do this now whilst it is empty than down the road. Granted, it's a nit, but a rather annoying one after spending a day or so typing it. :)
More All Messages By This Member
Edward Warnicke #70 Woot! on the patch :) I look forward to the outcome of the vote among the committers :) Ed toggle quoted message Show quoted text On Sat, May 14, 2016 at 3:17 PM, Keith Burns <alagalah@...> wrote: The patch to move nsh from VPP to nsh_sfc is published. I'd ask though that we don't merge it in lieu of a request. I'd like to rename the repo: nshsfc from nsh_sfc Can I get a vote from committers +1/-1/0 and if it passes I'll make a formal request to TSC and then helpdesk to have it changed. Would much rather do this now whilst it is empty than down the road. Granted, it's a nit, but a rather annoying one after spending a day or so typing it. :) _______________________________________________ nsh_sfc-dev mailing list nsh_sfc-dev@... https://lists.fd.io/mailman/listinfo/nsh_sfc-dev
More All Messages By This Member
Zhou, Danny #71 -1. I think nsh_sfc is clearer because both nsh and sfc are already abbreviation, combination of them to make nshsfc is hard to understand for new comers. toggle quoted message Show quoted text From: nsh_sfc-dev-bounces@... [mailto:nsh_sfc-dev-bounces@...] On Behalf Of Keith Burns Sent: Sunday, May 15, 2016 4:18 AM To: nsh_sfc-dev@... Subject: [nsh_sfc-dev] First patch and a request of committers The patch to move nsh from VPP to nsh_sfc is published. I'd ask though that we don't merge it in lieu of a request. I'd like to rename the repo: nshsfc from nsh_sfc Can I get a vote from committers +1/-1/0 and if it passes I'll make a formal request to TSC and then helpdesk to have it changed. Would much rather do this now whilst it is empty than down the road. Granted, it's a nit, but a rather annoying one after spending a day or so typing it. :)
More All Messages By This Member
Keith Burns <alagalah@...> #72 Would simply calling it nsh clear it up? It's only support for nsh header and its manipulation functions, how the control plane chooses to exercise those functions is really the SFC part. toggle quoted message Show quoted text On Sat, May 14, 2016, 6:47 PM Zhou, Danny <danny.zhou@...> wrote: -1. I think nsh_sfc is clearer because both nsh and sfc are already abbreviation, combination of them to make nshsfc is hard to understand for new comers. From: nsh_sfc-dev-bounces@... [mailto:nsh_sfc-dev-bounces@...] On Behalf Of Keith Burns Sent: Sunday, May 15, 2016 4:18 AM To: nsh_sfc-dev@... Subject: [nsh_sfc-dev] First patch and a request of committers The patch to move nsh from VPP to nsh_sfc is published. I'd ask though that we don't merge it in lieu of a request. I'd like to rename the repo: nshsfc from nsh_sfc Can I get a vote from committers +1/-1/0 and if it passes I'll make a formal request to TSC and then helpdesk to have it changed. Would much rather do this now whilst it is empty than down the road. Granted, it's a nit, but a rather annoying one after spending a day or so typing it. :)
More All Messages By This Member
Chris Luke #73 Not a committer, but I agree with Keith. For whatever that’s worth. :) Chris. toggle quoted message Show quoted text From: nsh_sfc-dev-bounces@... [mailto:nsh_sfc-dev-bounces@...] On Behalf Of Keith Burns Sent: Sunday, May 15, 2016 09:37 To: Zhou, Danny <danny.zhou@...>; nsh_sfc-dev@... Subject: Re: [nsh_sfc-dev] First patch and a request of committers Would simply calling it nsh clear it up? It's only support for nsh header and its manipulation functions, how the control plane chooses to exercise those functions is really the SFC part. On Sat, May 14, 2016, 6:47 PM Zhou, Danny <danny.zhou@...> wrote: -1. I think nsh_sfc is clearer because both nsh and sfc are already abbreviation, combination of them to make nshsfc is hard to understand for new comers. From: nsh_sfc-dev-bounces@... [mailto:nsh_sfc-dev-bounces@...] On Behalf Of Keith Burns Sent: Sunday, May 15, 2016 4:18 AM To: nsh_sfc-dev@... Subject: [nsh_sfc-dev] First patch and a request of committers The patch to move nsh from VPP to nsh_sfc is published. I'd ask though that we don't merge it in lieu of a request. I'd like to rename the repo: nshsfc from nsh_sfc Can I get a vote from committers +1/-1/0 and if it passes I'll make a formal request to TSC and then helpdesk to have it changed. Would much rather do this now whilst it is empty than down the road. Granted, it's a nit, but a rather annoying one after spending a day or so typing it. :)
More All Messages By This Member
Florin Coras #74 Also not a committer but Keith’s proposal does make sense to me. Florin toggle quoted message Show quoted text On May 15, 2016, at 5:15 PM, Luke, Chris <Chris_Luke@...> wrote: Not a committer, but I agree with Keith. For whatever that’s worth. :) Chris. From: nsh_sfc-dev-bounces@... [mailto:nsh_sfc-dev-bounces@...] On Behalf Of Keith Burns Sent: Sunday, May 15, 2016 09:37 To: Zhou, Danny <danny.zhou@...>; nsh_sfc-dev@... Subject: Re: [nsh_sfc-dev] First patch and a request of committers Would simply calling it nsh clear it up? It's only support for nsh header and its manipulation functions, how the control plane chooses to exercise those functions is really the SFC part. On Sat, May 14, 2016, 6:47 PM Zhou, Danny <danny.zhou@...> wrote: -1. I think nsh_sfc is clearer because both nsh and sfc are already abbreviation, combination of them to make nshsfc is hard to understand for new comers. From: nsh_sfc-dev-bounces@... [mailto:nsh_sfc-dev-bounces@...] On Behalf Of Keith Burns Sent: Sunday, May 15, 2016 4:18 AM To: nsh_sfc-dev@... Subject: [nsh_sfc-dev] First patch and a request of committers The patch to move nsh from VPP to nsh_sfc is published. I'd ask though that we don't merge it in lieu of a request. I'd like to rename the repo: nshsfc from nsh_sfc Can I get a vote from committers +1/-1/0 and if it passes I'll make a formal request to TSC and then helpdesk to have it changed. Would much rather do this now whilst it is empty than down the road. Granted, it's a nit, but a rather annoying one after spending a day or so typing it. :) _______________________________________________ nsh_sfc-dev mailing list nsh_sfc-dev@... https://lists.fd.io/mailman/listinfo/nsh_sfc-dev
More All Messages By This Member
Joel Halpern #75 While I am not a committer for this project, we had the discussion of whether to include the sfc term in the name during the project creation discussions. The project scope is NSH in the context of SFC. It is not any old use of NSH in any context. Scoping does matter. We had oroginally mde the mistake of using upper case in the repo name. I was (politely) told that the name of the repo needed to be a normal C variable (and yes, I do know that while syntactically legal, C coding conventions generally don't use upper case for variables.) So we made it lower case. Keith is there an actual problem with the underbar other than your dislike of typing it? Yours, Joel toggle quoted message Show quoted text On 5/15/16 9:37 AM, Keith Burns wrote: Would simply calling it nsh clear it up? It's only support for nsh header and its manipulation functions, how the control plane chooses to exercise those functions is really the SFC part. On Sat, May 14, 2016, 6:47 PM Zhou, Danny <danny.zhou@... <mailto:danny.zhou@...>> wrote: -1. ____ __ __ I think nsh_sfc is clearer because both nsh and sfc are already abbreviation, combination of them to make nshsfc is hard to understand for new comers.____ __ __ From:nsh_sfc-dev-bounces@... <mailto:nsh_sfc-dev-bounces@...> [mailto:nsh_sfc-dev-bounces@... <mailto:nsh_sfc-dev-bounces@...>] On Behalf Of Keith Burns Sent: Sunday, May 15, 2016 4:18 AM To: nsh_sfc-dev@... <mailto:nsh_sfc-dev@...> Subject: [nsh_sfc-dev] First patch and a request of committers____ __ __ The patch to move nsh from VPP to nsh_sfc is published. ____ __ __ I'd ask though that we don't merge it in lieu of a request. ____ __ __ I'd like to rename the repo: nshsfc from nsh_sfc ____ __ __ Can I get a vote from committers +1/-1/0 and if it passes I'll make a formal request to TSC and then helpdesk to have it changed. ____ __ __ Would much rather do this now whilst it is empty than down the road. ____ __ __ Granted, it's a nit, but a rather annoying one after spending a day or so typing it. ____ __ __ :)____ __ __ __ __ _______________________________________________ nsh_sfc-dev mailing list nsh_sfc-dev@... https://lists.fd.io/mailman/listinfo/nsh_sfc-dev
More All Messages By This Member
Keith Burns <alagalah@...> #76 Joel, You are absolutely correct on all counts. As I said, in the original email, it was a nit, pure and simple. I just hate typing it. It's just easier to address now before we open up for patches as iirc we can't "rename" but it's a net new repo and we would lose all commit history. I certainly don't have exclusivity on "the naming of things" and in fact there's no debate here at all. It would have had to have been unanimous agreement/ambivalence before moving it forward. Danny's objection is enough for me to withdraw the idea. Now, to fix the patch itself. It's my wedding anniversary today so honey-dos top the list today, followed by VPP reviews, etc. Appreciate the feedback, it's all good. Consider the idea withdrawn. Viva la nsh_sfc !!!! toggle quoted message Show quoted text On Sun, May 15, 2016, 9:08 AM Joel M. Halpern <jmh@...> wrote: While I am not a committer for this project, we had the discussion of whether to include the sfc term in the name during the project creation discussions. The project scope is NSH in the context of SFC. It is not any old use of NSH in any context. Scoping does matter. We had oroginally mde the mistake of using upper case in the repo name. I was (politely) told that the name of the repo needed to be a normal C variable (and yes, I do know that while syntactically legal, C coding conventions generally don't use upper case for variables.) So we made it lower case. Keith is there an actual problem with the underbar other than your dislike of typing it? Yours, Joel On 5/15/16 9:37 AM, Keith Burns wrote: > Would simply calling it nsh clear it up? It's only support for nsh > header and its manipulation functions, how the control plane chooses to > exercise those functions is really the SFC part. > > > On Sat, May 14, 2016, 6:47 PM Zhou, Danny <danny.zhou@... > <mailto:danny.zhou@...>> wrote: > > -1. ____ > > __ __ > > I think nsh_sfc is clearer because both nsh and sfc are already > abbreviation, combination of them to make nshsfc is hard to > understand for new comers.____ > > __ __ > > From:nsh_sfc-dev-bounces@... > <mailto:nsh_sfc-dev-bounces@...> > [mailto:nsh_sfc-dev-bounces@... > <mailto:nsh_sfc-dev-bounces@...>] On Behalf Of Keith Burns > Sent: Sunday, May 15, 2016 4:18 AM > To: nsh_sfc-dev@... <mailto:nsh_sfc-dev@...> > Subject: [nsh_sfc-dev] First patch and a request of committers____ > > __ __ > > The patch to move nsh from VPP to nsh_sfc is published. ____ > > __ __ > > I'd ask though that we don't merge it in lieu of a request. ____ > > __ __ > > I'd like to rename the repo: nshsfc from nsh_sfc ____ > > __ __ > > Can I get a vote from committers +1/-1/0 and if it passes I'll make > a formal request to TSC and then helpdesk to have it changed. ____ > > __ __ > > Would much rather do this now whilst it is empty than down the > road. ____ > > __ __ > > Granted, it's a nit, but a rather annoying one after spending a day > or so typing it. ____ > > __ __ > > :)____ > > __ __ > > __ __ > > > > _______________________________________________ > nsh_sfc-dev mailing list > nsh_sfc-dev@... > https://lists.fd.io/mailman/listinfo/nsh_sfc-dev >
More All Messages By This Member

1 - 8 of 8

1

Previous Topic Next Topic

Home Hashtags Subgroups Terms