Re: ENEA and HCL contributions to CSIT


Kinsella, Ray <mdr@...>
 

+1 legend

On 16/10/2020 14:07, Maciek Konstantynowicz (mkonstan) wrote:
Thanks Vratko, you’re a Star! M.

On 16 Oct 2020, at 13:38, Vratko Polak -X (vrpolak - PANTHEON TECH SRO at Cisco) <vrpolak@...> wrote:

Lucian's contribution is about 10-20 LoC, probably about 1hr or 2hr to rework by a volunteer.
Any volunteers ... ?
As I have looked at the contribution already,
I figured the hypothetical volunteer would spend
more time working on that that I would.
So [2] is now merged.

Hopefully, device tests will not start failing occasionally because of that. :)

Vratko.

[2] https://gerrit.fd.io/r/c/csit/+/29478

-----Original Message-----
From: tsc@... <tsc@...> On Behalf Of Kinsella, Ray
Sent: Monday, 2020-October-05 21:32
To: tsc@...; Florin Coras (fcoras) <fcoras@...>; Maciek Konstantynowicz (mkonstan) <mkonstan@...>
Subject: [tsc] ENEA and HCL contributions to CSIT

Folks,

I had a look at the ENEA and HCL contributions contributions to CSIT.
You can find them here:

* Lucian Banu (ENEA): https://git.fd.io/csit/commit/?id=4bafd0aa54fa78c4c3a6a32281cfa551e61bcafc

Lucian's contribution is about 10-20 LoC, probably about 1hr or 2hr to rework by a volunteer.
Any volunteers ... ?

* Nidhy (HCL): https://git.fd.io/csit/commit/?id=aafa2efa63b891e85ff13255691aae4909bc503c

Nidhy's contribution is substantial, adding the following test case.

LISP_IP4o4
LISPGPE_IP4o4
LISPGPE_IP6o4
LISPGPE_IP6o4.
LISPGEP_IP4o6
LISPGPE_IP6o6

CC'ing Florin (LISP maintainer) to understand, what is the impact if we need to excise these Test Cases without rework.

Thanks,

Ray K

Join {tsc@lists.fd.io to automatically receive all group messages.