Re: flag day to enable API flag day process

Dave Wallace
 

Vratko,

Why was the CSIT patch merged without being reviewed by a non-author?

The job has been reverted to non-voting, because the CRC's contained in the script are behind the current version of src/vnet/ip/ip_types.api, thus on rebasing a patch to HEAD the job votes -1.

Thanks,
-daw-

On 7/31/2019 12:37 PM, Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) wrote:

[1] is now merged, job is created, and I see [3] it passing.

Vratko.

[3] https://jenkins.fd.io/job/vpp-csit-verify-api-crc-master/2/console

 

From: Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco)
Sent: Wednesday, July 31, 2019 10:41 AM
To: 'vpp-api-dev@...' <vpp-api-dev@...>; 'vpp-dev@...' <vpp-dev@...>; 'csit-dev' <csit-dev@...>
Cc: 'Dave Wallace (dwallacelf@...)' <dwallacelf@...>; Ed Kern (ejk) <ejk@...>
Subject: RE: flag day to enable API flag day process

 

[0] is merged, but [1] is stuck due to [2].

Vratko.

[2] https://lists.fd.io/g/vpp-dev/message/13627

 

From: Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco)
Sent: Monday, July 22, 2019 7:14 PM
To: vpp-api-dev@...; vpp-dev@...; csit-dev <csit-dev@...>
Cc: Dave Wallace (dwallacelf@...) <dwallacelf@...>; Ed Kern (ejk) <ejk@...>
Subject: flag day to enable API flag day process

 

The main API flag document: [0].

 

I have most of implementation ready,

see [1] and comments there.

 

The missing parts is e-mail alerting

and postponing main vpp verify jobs

until API check passes (older stable/ VPP branches

are tricky to support in that way).

 

Please review, I would like to merge very soon.

 

Keeping CSIT list updated without automated

verify jobs takes some effort,

and it is pointless to add CRC checking only into CSIT

if VPP is not gated against API changes.

That is why both CSIT and ci-management parts

have to be merged together.

 

I will add the missing features

once the new verification is enabled.

 

Vratko.

 

[0] https://gerrit.fd.io/r/18356

[1] https://gerrit.fd.io/r/20708


Join vpp-api-dev@lists.fd.io to automatically receive all group messages.